web: update web-sys to 0.3.58, sparse attachments support #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, and I noticed a CI failure that doesn't look like it was caused by this PR? --- STDERR: wgpu::example/hello-compute tests::test_multithreaded_compute ---
[467](https://github.com/gfx-rs/wgpu/runs/7065980115?check_suite_focus=true#step:13:468)
error: XDG_RUNTIME_DIR not set in the environment.
[468](https://github.com/gfx-rs/wgpu/runs/7065980115?check_suite_focus=true#step:13:469)
error: XDG_RUNTIME_DIR not set in the environment.
[469](https://github.com/gfx-rs/wgpu/runs/7065980115?check_suite_focus=true#step:13:470)
WARNING: lavapipe is not a conformant Vulkan implementation, testing use only. |
|
That one's been a rare but spurious failure, so just ignore it |
jinleili
changed the title
|
Want to give it a once over on my computer tomorrow, but I don't see any major issues. |
|
Another code change that looks awkward is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
#2795
sparse attachments support need
web-sysupgrade: #2778Description
From web-sys 0.3.58, call
GpuRenderPipelineDescriptorGpuComputePipelineDescriptor::new() need a "non-null" layout argument, so when desc.layout is none,wasm_bindgen::JsValue::from(web_sys::GpuAutoLayoutMode::Auto)is used and tested on Chrome Canary.Testing
Tested
cubehellow-trianglehellow-computemipmapmasa-lineexamples on Chrome Canary (v105.0.5144.0), Other examples have many warnings in theConsolepanel, but none of them are relevant to this update.