metal: set max_buffer_size
by the correct physical device restriction
#2502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
The wgpu matrix room mentions the 256MB restriction on macOS several times:
Description
But starting from iOS 12 and macOS 10.14, there is a
maxBufferLength
property can used to query max buffer size.In addition, since
[view convertRect: toCoordinateSpace:]
only affects x, y coordinates, deleting it from surfacefn dimentions
does not affect correctness, gettingbounds
andcontentsScale
from metalLayer is guaranteed.Testing
Tested on these devices: