web: Implement Device::on_uncaptured_error #2132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
#2130
Description
This PR is a first pass at wiring up
Device::on_uncaptured_error
on web, mapping the WebGPU errors intowgpu::Error
.Possible improvements:
Error::source
value is bogus.wasm_bindgen::Closure::forget
, this will leak the memory associated with the closure. This seemed okay for a one-off diagnostic function, and also can be avoided by enabling weak references, available on all major browsers now. Alternatively, a map would need to be maintained between devices and their error handler.Testing
Tested it in Ruffle to catch errors thrown by Chrome on certain platforms.