Add pipeline statistics and timeline queries#1128
Conversation
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
|
Alright, this is still blocked on gfx updates and I need to add queries to traces, but the core changes are ready for second pass review. |
|
Traces are added |
cwfitzgerald
force-pushed
the
queries
branch
3 times, most recently
from
f16db06 to
bbdd653
Compare
kvark
left a comment
kvark
left a comment
There was a problem hiding this comment.
Please read all the comments before starting to address them :)
Thank you for your patience!
wgpu-core/src/command/query.rs
Outdated
| query_type: SimplifiedQueryType, | ||
| query_set_id: id::QuerySetId, | ||
| query_index: u32, | ||
| reset_state: &mut Option<&mut QueryResetMap>, |
There was a problem hiding this comment.
oh wow, first time seeing this pattern!
Why is it not just reset_state: Option<&mut QueryResetMap>?
There was a problem hiding this comment.
Because I need to use the option later on as well. If I pass it by value I can't use it later in the function. I need to get (from the option) a &mut &mut QueryResetMap, which is only possible when the reference to the option is also mut.
|
Finishing up wgpu-rs PR then I'll undraft, ready for round 3 review. |
|
Everything seems to work fine, so we're good to go :) |
kvark
left a comment
kvark
left a comment
There was a problem hiding this comment.
Amazing work, the code looks great!
Just a few small nits, one of them (about the query size check) needs to be addressed, others up to your consideration.
|
Addressed; Thanks for the detailed reviews :) bors r=kvark |
715: Add pipeline statistics and timeline queries r=kvark a=cwfitzgerald Blocked on gfx-rs/wgpu#1128. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
715: Add pipeline statistics and timeline queries r=kvark a=cwfitzgerald Blocked on gfx-rs#1128. Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
2 participants
Connections
Closes #721
Description
This adds Pipeline Statistics queries and Timeline queries. Shoutout to @z2oh for doing a good chunk of the work to enable this feature.
Currently blocked on both gfx-rs/gfx#3563 and rollup of gfx-hal mutability changes, but is ready to review.
Testing
Tested in various ways on the hello-compute and hello-triangle example, tested validation extensively. Queries will be permanently added to the mipmap example once the wgpu-rs PR is finished.