Skip to content

[core-remote] Use mutability from RefCell<Hub> for Registry and remove FutureId - #10080

Merged
teoxoy merged 2 commits into
gfx-rs:trunkfrom
sagudev:les-refcell
Aug 17, 2026
Merged

[core-remote] Use mutability from RefCell<Hub> for Registry and remove FutureId#10080
teoxoy merged 2 commits into
gfx-rs:trunkfrom
sagudev:les-refcell

Conversation

@sagudev

@sagudev sagudev commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Connections
Towards #10073

Description
As outlined in #10074 (comment) we replace refcell in Registery with RefCell. I am very happy with end results as there are no more guards and much only one borrow per global method.

In second commit I remove FutureId because we do not need it really anymore (it made sense when it did not hold &mut) and it's unnecessary complication.

Testing
Just refactor.

Squash or Rebase?
Rebase.

Checklist

  • I self-reviewed and fully understand this PR.
  • WebGPU implementations built with wgpu may be affected behaviorally.
  • Validation and feature gates are in place to confine behavioral changes.
  • Tests demonstrate the validation and altered logic works.
  • CHANGELOG.md entries for the user-facing effects of this change are present.
  • The PR is minimal, and doesn't make sense to land as multiple PRs.
  • Commits are logically scoped and individually reviewable.
  • The PR description has enough context to understand the motivation and solution implemented.

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
@sagudev
sagudev requested a review from teoxoy August 15, 2026 06:03
@teoxoy teoxoy self-assigned this Aug 17, 2026

@teoxoy teoxoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@teoxoy
teoxoy merged commit b6b1e76 into gfx-rs:trunk Aug 17, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants