Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect function call #432

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

fyellin
Copy link
Contributor

@fyellin fyellin commented Sep 28, 2024

Partial fix for #429.

"C" wrapper was calling the wrong Rust method.

@Korijn
Copy link
Contributor

Korijn commented Sep 28, 2024

Sorry for that approval, I didn't notice it was another repo, haha!

@fyellin
Copy link
Contributor Author

fyellin commented Sep 29, 2024

@almarklein

Korijn approved this pull by request by mistake. It will not led me add you as a reviewer. One line fix for an obvious copy-and-paste error.

Copy link
Collaborator

@almarklein almarklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a typo to me indeed 👍

@fyellin
Copy link
Contributor Author

fyellin commented Sep 30, 2024

@almarklein I do not have write access. I cannot do the merge.

@almarklein
Copy link
Collaborator

On this repo I usually don't merge before @rajveermalviya has had a look, but this looks rather obvious, so let's merge.

@almarklein almarklein merged commit f8b5cf5 into gfx-rs:trunk Sep 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants