Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wgsl-in] Avoid splatting all binary operator expressions #2440

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

fornwall
Copy link
Contributor

Fixes #2439.

Reference:
Screenshot 2023-08-16 at 12 08 10

@fornwall fornwall changed the title [wgsl-in] Avoid splatting too many binary operator expressions [wgsl-in] Avoid splatting all binary operator expressions Aug 16, 2023
src/front/wgsl/lower/mod.rs Show resolved Hide resolved
@fornwall fornwall requested a review from teoxoy August 18, 2023 11:01
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@teoxoy teoxoy merged commit 3da9355 into gfx-rs:master Aug 18, 2023
6 checks passed
@Wumpf
Copy link
Member

Wumpf commented Aug 18, 2023

awesome, thanks for picking this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wgsl-in] Comparing scalar with vector type incorrectly passes validation
3 participants