Omit non referenced expressions #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems HLSL validation is failing on gfx-rs/wgpu#4555 which should be fixed by #2367. |
jimblandy
approved these changes
Jun 12, 2023
| arg, | ||
| arg1, | ||
| arg2, | ||
| arg3, |
There was a problem hiding this comment.
Nice catch. I think I've seen several of these fixed recently. I did a quick look and I think this must the last - the other places that use Math { .. } are sites that can't produce results at all without the arguments, so .. is probably okay there.
| @@ -868,7 +873,7 @@ impl FunctionInfo { | |||
| S::Loop { | |||
| ref body, | |||
| ref continuing, | |||
| break_if: _, | |||
| break_if, | |||
jimblandy
force-pushed
the
omit-non-ref-exprs
branch
from
402c897
to
96a7b1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.