Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Expression::ZeroValue. #2332

Merged
merged 2 commits into from
May 11, 2023
Merged

Conversation

jimblandy
Copy link
Member

@jimblandy jimblandy commented May 10, 2023

This is part of #2266. This change causes a lot of changes to the test output, so it's easier to review the rest of the constexpr work with this factored out.

This is all authored by @teoxoy; I just separated it out. I'll figure out how to fix up the commit author before we land this.

This needs to be rebased on #2331.

@jimblandy
Copy link
Member Author

@teoxoy, if you could look over the two commits here that are not part of #2331 and make sure I've done a reasonable job extracting ZeroValue from the rest, that'd be great.

Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member Author

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@jimblandy jimblandy merged commit 4d87401 into gfx-rs:master May 11, 2023
@jimblandy jimblandy deleted the zero-value branch September 20, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants