-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spv-out: support version 1.4 #2230
Conversation
@teoxoy unfortunately the test validation is blocked on a thing. Our |
I think it would be feasible to read the version from the file and map it to a vulkan version but that sounds quite involved. |
I think we should just merge this with some sort of a workaround, not blocking for a general solution (be it subfolders or not). Even without a test would be fine, since it's not a regression. |
8ac533c
to
b7e5742
Compare
@teoxoy PR now comes with the general solution that extracts SPV version from the comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR now comes with the general solution that extracts SPV version from the comment
That's great, thanks for addressing it here!
Looks like 1.4 expects all global variables to be a part of the interface: