Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workgroup uniform load #2201

Merged
merged 15 commits into from
May 26, 2023
Merged

Workgroup uniform load #2201

merged 15 commits into from
May 26, 2023

Conversation

DJMcNab
Copy link
Contributor

@DJMcNab DJMcNab commented Jan 10, 2023 •
edited
Loading

Fixes #2191

teoxoy
teoxoy requested changes Feb 3, 2023
View reviewed changes
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Have a few comments but overall looks good.

src/lib.rs Outdated Show resolved Hide resolved
src/valid/function.rs Outdated Show resolved Hide resolved
src/valid/expression.rs Outdated Show resolved Hide resolved
tests/out/wgsl/workgroupUniformLoad.wgsl Outdated Show resolved Hide resolved
src/back/glsl/mod.rs Outdated Show resolved Hide resolved
@jimblandy
Copy link
Member

Tragically, this predates #2075 by three commits, so the WGSL front end changes need to be rebased.

jimblandy
jimblandy requested changes Feb 17, 2023
View reviewed changes
tests/in/workgroupUniformLoad.wgsl Outdated Show resolved Hide resolved
jimblandy
jimblandy requested changes Feb 22, 2023
View reviewed changes
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; sorry about the misunderstanding. This just needs to be rebased over the #2075 changes, then.

tests/in/workgroupUniformLoad.wgsl Outdated Show resolved Hide resolved
@DJMcNab DJMcNab requested a review from teoxoy May 4, 2023 14:02
teoxoy
teoxoy reviewed May 9, 2023
View reviewed changes
src/valid/expression.rs Outdated Show resolved Hide resolved
src/valid/analyzer.rs Outdated Show resolved Hide resolved
DJMcNab and others added 3 commits May 9, 2023 12:05
@DJMcNab @teoxoy
Correct error message
ba3941b 
Co-authored-by: Teodor Tanasoaia <[email protected]>
@DJMcNab
Fix formatting
f55c49b
@DJMcNab @jimblandy
Update comment
993b639 
Co-Authored-By: Jim Blandy <[email protected]>
@DJMcNab DJMcNab requested review from teoxoy and jimblandy May 26, 2023 18:14
@jimblandy jimblandy merged commit 907b7c7 into gfx-rs:master May 26, 2023
@DJMcNab DJMcNab deleted the workgroupUniformLoad branch May 26, 2023 20:35
@teoxoy teoxoy mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoxoy teoxoy teoxoy approved these changes

@jimblandy jimblandy jimblandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement workgroupUniformLoad
3 participants
@DJMcNab @jimblandy @teoxoy