Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spv-out] Don't emit no-op OpBitCast instructions. #2043

Merged
merged 1 commit into from
Sep 3, 2022
Merged

[spv-out] Don't emit no-op OpBitCast instructions. #2043

merged 1 commit into from
Sep 3, 2022

Conversation

jimblandy
Copy link
Member

As reported in #2015, some drivers trip over these.

@jimblandy
[spv-out] Don't emit no-op OpBitCast instructions.
da9838e 
As reported in gfx-rs#2015, some drivers trip over these.
@jimblandy jimblandy added lang: SPIR-V Binary SPIR-V input and output area: back-end Outputs of shader conversion type: enhancement labels Sep 2, 2022
@jimblandy jimblandy mentioned this pull request Sep 2, 2022
Closed
JCapucho
JCapucho approved these changes Sep 3, 2022
View reviewed changes
Copy link
Collaborator

@JCapucho JCapucho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JCapucho JCapucho merged commit 7505187 into gfx-rs:master Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCapucho JCapucho JCapucho approved these changes

Assignees
No one assigned
Labels
area: back-end Outputs of shader conversion lang: SPIR-V Binary SPIR-V input and output type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimblandy @JCapucho