New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glsl-in: Stop emitter in conditional #1952

Merged

jimblandy merged 1 commit into gfx-rs:master from JCapucho:glsl-in-conditional-emit-end

May 30, 2022

Collaborator

JCapucho commented May 27, 2022

This wasn't being done when there were no implicit conversions, causing
the emitter to panic.

closes #1942


          glsl-in: Stop emitter in conditional

965277e

This wasn't being done when there were no implicit conversions, causing
the emitter to panic.

jimblandy reviewed

View reviewed changes

Member

jimblandy left a comment

Ah, sorry I didn't catch this in the first review. Thanks for the fix.

jimblandy approved these changes

View reviewed changes

jimblandy merged commit 9e75332 into gfx-rs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet