chore: remove unnecessary license clause #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting this field makes the entire GPLv2 license text appear when viewing the package metadata e.g with `pip show flake8-builtins`. I feel this is a bit too verbose, and unnecessary. As described in the [python packaging guide] it is not necessary to specify this field when using a standard license. Actually this might be more confusing to users, as they may avoid the package if a modified license is implied: > If you are using a standard, well-known license, it is not necessary > to use this field. Instead, you should one of the classifiers starting > with License ::. (As a general rule, it is a good idea to use a > standard, well-known license, both to avoid confusion and because some > organizations avoid software whose license is unapproved.) [python packaging guide]: https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license
|
Sorry for the late response 😓 I did not even now that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting this field makes the entire GPLv2 license text appear when viewing the package metadata, e.g. with
pip show flake8-builtins.I feel this is a bit too verbose, and unnecessary.
As described in the python packaging guide it is not necessary to specify this field when using a standard license. Actually, this might be more confusing to users, as they may avoid the package if a modified license is implied:
Since this package already uses the 'License' classifier, I think removing this from
pyproject.tomlshould remove it from the metadata when uploading to pypi with hatchling.