Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insert_anchor_links back to config.toml #2767

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

9999years
Copy link

@9999years 9999years commented Jan 12, 2025

Discourse thread: https://zola.discourse.group/t/add-insert-anchor-links-back-to-config-toml/2441


insert_anchor_links was a valid config.toml setting before 0.0.6 but was changed to a section option.

It was mentioned in the documentation for config.toml until 2021 (#1477).

In 2021, @Keats said that "insert_anchor_links could probably be a config option in config.toml":
#634 (comment)

In the same thread, several other users requested this feature. @Artoria2e5 said:

These sort of settings become annoying to copy-paste when a site ends
up with many sections.

@ctron said:

But even more annoying is that it seems I can't add
insert_anchor_links on the top section, but need to place it in every
section.

I think having this as a default configuration for the site makes
total sense.

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Are you doing the PR on the next branch?
  • Have you created/updated the relevant documentation page(s)?

`insert_anchor_links` was a valid `config.toml` setting before [0.0.6]
but was changed to a section option.

[0.0.6]: https://github.com/getzola/zola/blob/master/CHANGELOG.md#006-2017-05-24

It was mentioned in the documentation for `config.toml` until 2021
(getzola#1477).

In 2021, @Keats said that "`insert_anchor_links` could probably be a
config option in `config.toml`":
getzola#634 (comment)

In the same thread, several other users requested this feature.
@Artoria2e5 said:

> These sort of settings become annoying to copy-paste when a site ends
> up with many sections.

@ctron said:

> But even more annoying is that it seems I can't add
> insert_anchor_links on the top section, but need to place it in every
> section.
>
> I think having this as a default configuration for the site makes
> total sense.
@Keats
Copy link
Collaborator

Keats commented Jan 13, 2025

LGTM, any reason it's a draft?

@9999years 9999years marked this pull request as ready for review January 13, 2025 19:57
@9999years
Copy link
Author

any reason it's a draft?

The contributing docs said to open a Discourse thread for feature requests and I wasn't sure if that meant I would be kicked out for opening a PR too hastily :)

@Keats Keats merged commit 3294bc0 into getzola:next Jan 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants