Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(taxonomies): fix error messages #2591

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix(taxonomies): fix error messages #2591

merged 1 commit into from
Aug 1, 2024

Conversation

samueltardieu
Copy link
Contributor

  • Some error messages refer to get_taxonomy_term_by_name instead of get_taxonomy_term
  • If a term cannot be found in a taxonomy, the error message erroneously pretends that the taxonomy itself is unknown instead of the term.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

  • Are you doing the PR on the next branch?

@samueltardieu
fix(taxonomies): fix error messages
8d211c5 
- Some error messages refer to `get_taxonomy_term_by_name` instead of
`get_taxonomy_term`
- If a term cannot be found in a taxonomy, the error message
erroneously pretends that the taxonomy itself is unknown instead of
the term.
Keats
Keats approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@Keats Keats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Keats Keats merged commit 88bd972 into getzola:next Aug 1, 2024
5 checks passed
reujab pushed a commit to reujab/zola that referenced this pull request Aug 14, 2024
@samueltardieu @reujab
fix(taxonomies): fix error messages (getzola#2591)
3b0de41 
- Some error messages refer to `get_taxonomy_term_by_name` instead of
`get_taxonomy_term`
- If a term cannot be found in a taxonomy, the error message
erroneously pretends that the taxonomy itself is unknown instead of
the term.
Keats pushed a commit that referenced this pull request Aug 15, 2024
@samueltardieu @Keats
fix(taxonomies): fix error messages (#2591)
9594fa8 
- Some error messages refer to `get_taxonomy_term_by_name` instead of
`get_taxonomy_term`
- If a term cannot be found in a taxonomy, the error message
erroneously pretends that the taxonomy itself is unknown instead of
the term.
berdandy pushed a commit to berdandy/azola that referenced this pull request Sep 17, 2024
@samueltardieu @berdandy
fix(taxonomies): fix error messages (getzola#2591)
7f4ccda 
- Some error messages refer to `get_taxonomy_term_by_name` instead of
`get_taxonomy_term`
- If a term cannot be found in a taxonomy, the error message
erroneously pretends that the taxonomy itself is unknown instead of
the term.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keats Keats Keats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samueltardieu @Keats