Refactor: create_directory responsibly #2407
Conversation
…ry, and misleading
…d of manually iterating over components
| @@ -977,8 +970,6 @@ impl Site { | |||
|
|
|||
| /// What it says on the tin | |||
| pub fn render_sitemap(&self) -> Result<()> { | |||
| ensure_directory_exists(&self.output_path)?; | |||
There was a problem hiding this comment.
I'd rather keep those around even if in theory it's already created elsewhere
There was a problem hiding this comment.
The reason why I removed it here is because write_content always creates directories when called, so, you can rely on that instead of creating them ahead of time.
This is why the only remaining instances where directories created are there, and when copying assets.
There was a problem hiding this comment.
It's ok in the grand scheme of things but creates inter-dependencies in case we decide to not use write_content for some reason. Maybe it's fine.
There was a problem hiding this comment.
That's fair. My thought process was that we should delay creating the directory as long as possible to avoid making them unnecessarily, but I'm open to adding back in checks that are guarded on whether things will actually be written.
* Remove ensure_directory_exists since it's identical to create_directory, and misleading * Don't create directories unless needed; rely on create_dir_all instead of manually iterating over components
* Remove ensure_directory_exists since it's identical to create_directory, and misleading * Don't create directories unless needed; rely on create_dir_all instead of manually iterating over components
* Remove ensure_directory_exists since it's identical to create_directory, and misleading * Don't create directories unless needed; rely on create_dir_all instead of manually iterating over components
These are the first two commits of #2388 separated into their own PR. Specifically:
ensure_directory_existswas made identical tocreate_directory. I removed the former and replaced all instances with the latter.create_directoryiteratively on every component despite it usingcreate_dir_allinternally. I decided to update these to have fewercreate_directorycalls so they could be better tracked.