Allow IPv6 serve, default base_url to listen interface instead of 127.0.0.1
#2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarfonthey
force-pushed
the
socket-addr
branch
from
f54a4e7 to
209bf98
Compare
clarfonthey
force-pushed
the
socket-addr
branch
from
209bf98 to
d99b98d
Compare
clarfonthey
changed the title
SocketAddrV4 => SocketAddrbase_url to listen interface instead of 127.0.0.1
clarfonthey
force-pushed
the
socket-addr
branch
from
e702a4a to
aa33ba9
Compare
Keats
approved these changes
Jan 7, 2024
veluca93
pushed a commit
to veluca93/zola
that referenced
this pull request
May 14, 2024
…27.0.0.1 (getzola#2395) * Parse interface as IpAddr, allow IPv6. * Default base_url to socket address, instead of 127.0.0.1
Keats
pushed a commit
that referenced
this pull request
Jun 20, 2024
…27.0.0.1 (#2395) * Parse interface as IpAddr, allow IPv6. * Default base_url to socket address, instead of 127.0.0.1
berdandy
pushed a commit
to berdandy/azola
that referenced
this pull request
Sep 17, 2024
…27.0.0.1 (getzola#2395) * Parse interface as IpAddr, allow IPv6. * Default base_url to socket address, instead of 127.0.0.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nextbranch?This could work fine if you just replaced
SocketAddrV4withSocketAddr, but I decided to tidy things up a bit more while I was looking at it. The main changes:zola servewill make thebase_urlequal to the interface it's listening on by default (prevents you from doingzola serve -i (thing) -u (same thing))interfaceexplicitly as an IP address instead of just parsing(interface):portas a socket address. This means that you should provide IPv6 addresses without the brackets and thatbase_urlwill automatically add the brackets as needed.