Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudflare docs update: Now requires changing build system version #2253

Closed
wants to merge 2 commits into from

Conversation

Incognito
Copy link

Documentation change.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Here's a screenshot to help the reviewer understand what I was looking at when I wrote this text:

Screenshot from 2023-07-21 08-49-51

@Keats
Copy link
Collaborator

Keats commented Jul 21, 2023

So it's not installed automatically anymore? Is there a forum/repo to see what's the recommended way to get Zola in the latest version?

@Incognito
Copy link
Author

@Keats It wasn't the default when I went to create a new site yesterday, they defaulted to version 2 and the deploy failed because Zola was not installed.

I didn't see any discussion in Cloudflare's forums about this.

@asimpletune
Copy link
Contributor

Hi @Keats and @Incognito, I came to this thread because I saw this user was having issues on the zola forum https://zola.discourse.group/t/cloudflare-pages-does-not-recognize-zola-and-build-fails/1814/2.

The only discussion for Cloudflare that I've seen is in this issue here cloudflare/pages-build-image#1 (comment). I don't think Cloudflare has a public repository for the actual build image supporting pages. Judging from that thread, and sos the best way to get in touch with the developer is via the #⁠pages-build-system-v2-beta channel in their discord https://discord.com/invite/cloudflaredev. There are also more details in the official pages build system documentation here https://developers.cloudflare.com/pages/platform/language-support-and-tools/

I haven't tried rebuilding any of my zola + CF sites yet, but I will try that out today and see what the process looks like both for an existing zola + CF site as well as a new one.

@asimpletune
Copy link
Contributor

I submitted cloudflare/pages-build-image#3 to start a discussion around getting Zola supported by default for the pages v2 build system

@asimpletune
Copy link
Contributor

Old builds still work, but new Zola projects do break and so until something changes users will have to use the UI to override the default build version.

Screenshot 2023-07-23 at 11 02 33 AM

One last thing to note is this line from the docs above

If you want to set a specific version of a framework your Cloudflare Pages project is using, note that Pages will respect your package manager of choice during your build process

Theoretically that would mean a cargo file could specify Zola as a dependency, but a.) Zola doesn't have a published crate and b.) that same documentation doesn't have Rust is a supported language.

Anyways, just food for thought. Hope that's helpful in case @Keats doesn't have a CF account, and I hope that not too many new Zola users run into issues before this can be made more ergonomic.

@Keats
Copy link
Collaborator

Keats commented Nov 30, 2023

Updated in more details in the PR above. Thanks!

@Keats Keats closed this Nov 30, 2023
@michael-conrad
Copy link

Please fix this documentation so new Zola users don't think you don't care about us at all.

@asimpletune
Copy link
Contributor

Hi @michael-conrad can you be more specific about your problem? The document change in this PR is found here or was there something else?

@michael-conrad
Copy link

I had to do a google search to find this documentation, if it is now merged so that others don't run into the same issue with the v1 vs v2 mess, great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants