feat: External URL redirect #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you do the PR on the |
|
Done! |
Keats
requested changes
Jan 22, 2023
|
Ok! It took me some time to find the right place to insert the checks, but I think I've got it. Is it better now? |
|
Yep it looks ok. Just need a rebase and a test that the alias is added to the external links. |
kartva
force-pushed
the
external-URL-redirect
branch
from
89fd0e4 to
66dc9bd
Compare
|
Done, done. |
Keats
approved these changes
Feb 9, 2023
|
Looks like everything is failing because of |
|
Don't worry about that |
Keats
approved these changes
Feb 11, 2023
Keats
pushed a commit
that referenced
this pull request
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1844
Code changes
Moved
is_external_linktoutils::net. Not the best place, I'm open to suggestions for better named modules or puttingis_external_linkinutils.