Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify embedded css and js with additional lib flags #1922

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

JeremyBarbosa
Copy link
Contributor

IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.

The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

  • Are you doing the PR on the next branch?

If the change is a new feature or adding to/changing an existing one:

  • Have you created/updated the relevant documentation page(s)?

^ I don't believe any documentation changes are required with the existing documentation mentioning that "the generated HTML files are minified."

Notes

A small fix for #1765. Just two extra config options so that the already included minify-html library also minifies CSS and JS.

@Keats
Copy link
Collaborator

Keats commented Jul 15, 2022

Did they change the backing compiler in a minor version?

@JeremyBarbosa
Copy link
Contributor Author

JeremyBarbosa commented Jul 15, 2022

It appears that in version 0.9.0, minify-html now uses the minify-js rust library to minify CSS and JS. Before 0.9.0, minifing CSS and JS was handled by esbuild-rs, which relied on the Go compiler.

So minify-html just seems to have switched to a lighter weight dependency that removes the Go requirement.

Here is the commit in minify-html where they changed the dependency,

@Keats
Copy link
Collaborator

Keats commented Jul 15, 2022

Thanks. I think I will wait a bit till those crates are a bit more tested and will merged that for 0.17 rather than 0.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants