Bugfix check links i18n (close #1694) #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 25, 2022 19:58
Display more advanced information in case of a future crash here
…la#1694 It appears linking to another translated page does not trigger the bug, but linking to a section within the same (translated) page does.
Keats
reviewed
Feb 26, 2022
components/site/src/link_checking.rs
Outdated
| // NOTE: This will also match _index.foobar.md where foobar is not a language | ||
| // I don't think this is supported by zola so nothing should be broken | ||
| // Will also prevent having a section like content/_index.foobar/_index.md | ||
| if md_path.contains("/_index.") { |
There was a problem hiding this comment.
Does the root section starts with /? I can't remember
There was a problem hiding this comment.
Very good point i removed the / as initially suggested on #1694. I added a note in the docs that any page whose path contains _index. is unsupported.
Keats
approved these changes
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced the same problem as described in #1694. I added the fix suggested over there, as well as a test: internal link in blog/_index.fr.md panics the whole build on the current next branch but passes with this test