Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo: run rustfmt on the codebase #1420

Closed
wants to merge 1 commit into from
Closed

Conversation

lucab
Copy link
Contributor

@lucab lucab commented Mar 30, 2021

This applies a rustfmt pass on the whole project, in order to avoid
spurious reflows while working on unrelated changes.


Sanity checks:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Are you doing the PR on the next branch?
  • Have you created/updated the relevant documentation page(s)?
    • LB: Not applicable

This applies a rustfmt pass on the whole project, in order to avoid
spurious reflows while working on unrelated changes.
@lucab
Copy link
Contributor Author

lucab commented Mar 30, 2021

/cc @Keats

@Keats
Copy link
Collaborator

Keats commented Mar 30, 2021

Thanks for that but it will cause merge issues with #1391 which I'm planning to merge in next this week.

@Keats Keats closed this Mar 30, 2021
@lucab
Copy link
Contributor Author

lucab commented Mar 30, 2021

@Keats no worries. I was playing around the codebase to see how feasible it is to implement backlinks, and noticed a few spurious reflows. Can you maybe throw a cargo fmt pass on top of #1391, whenever you are done?

@Keats
Copy link
Collaborator

Keats commented Mar 30, 2021

Interesting, backlinks is the feature I want to add after the i18n changes!

@lucab
Copy link
Contributor Author

lucab commented Mar 30, 2021

Nice. I am not yet there though, as I am slowly wading through the codebase and plumbing through primitives. I guess I can start opening PRs for those as soon as polished, though.

@lucab lucab deleted the ups/rustfmt branch March 30, 2021 17:13
@sgued sgued mentioned this pull request Oct 30, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants