Make current_path always start with a slash #1101
Conversation
Change tests accordingly
…") and TaxonomyItem ("some-tag")
Fix Paginator.path missing trailing slash in from_taxonomy() Change tests accordingly
This requires adding two dummy pages in the content root.
A string formatting such as {name: value} can help prevent this.
|
I checked all the items, but of course that doesn't mean things are fully done, e.g. there can be always more and better tests; but since this is my first PR ever, I hope I can get some early feedback from @Keats so that effort can be better directed :) |
Sweating as I have no comments, this looks great! Thanks a lot |
|
Pardon my oversharing, but I wasn't having a great day today, and your kind words totally made my day! The direction you gave me was everything I needed to get started and work through the pieces as a first-timer, so thank you, for making this task that much more approachable than I was expecting. It's my pleasure to contribute to something we all find tremendously useful! |
#1086
Checklist (source)
colocated asset(ref)