page.summary only works when isolated on a newline.

[digitalillusions]

Bug Report

I've upgraded from Zola 0.18.0 to 0.19.1 today and found that my use of page.summary is broken.

When writing the <!-- more --> tag inline into markdown content, the page.summary variable does not get populated. For example

Hello hello <!-- more --> this is a test.

will not work. However,

Hello hello
<!-- more -->
this is a test

will work. Unfortunately, this will add a newline between Hello hello and this is a test when using page.content, which is a bummer because now I cant take part of a paragraph as a page summary anymore.

It would be cool to get back the functionality for <!-- more --> to be inlinable. I assume this might have something to do with the recent fix for footnotes?

Environment

Zola version: 0.19.1

[Keats]

It might be related to the pulldown-cmark update, I don't see other changes that could be related (other than the regex change but that shouldn't change anything there).

Honestly I don't think it was ever intented to work the inline way? We're looking for it in the HTML event and the actual intent was always to have it be on a new line.

[digitalillusions]

Ah, I see. Well, it was a very nice feature to have, since I don't always want to have a full paragraph in the summary, but maybe just a few sentences.

In any case, I think the docs could mention the limitations of the <!-- more --> tag.

[ChrisRenfrow]

I came here because I noticed the same thing, looks like this bug I and others depended on as a feature can no longer be exploited. 😄

[Keats]

Did you never have issues with unclosed HTML tags by using it inline? Since we just slice the rendered content it's unlikely the HTML would be valid in a lot of cases

[digitalillusions]

Sorry, I totally forgot to reply. It indeed causes an unclosed <p> tag for me, which now that I know about it is obviously not ideal. I never actually noticed this, because the rendered HTML never showed any artifacts. I will just lave this comment here for completeness in case anyone else stumbles across this issue.