Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update themes #121

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Update themes #121

merged 1 commit into from
Aug 20, 2023

Conversation

Keats
Copy link
Collaborator

@Keats Keats commented Aug 20, 2023

No description provided.

@Keats Keats merged commit 3721b9b into master Aug 20, 2023
@Keats Keats deleted the update branch August 20, 2023 12:37
@welpo
Copy link
Contributor

welpo commented Aug 20, 2023

Hi,

Was this supposed to update all themes? I see some are missing from the commit (like tabi).

Even Abridge, which is on the commit, still shows an older README text on the site (I now see it's because the main zola repo needs to be updated with the new docs).

On a related note, what are the steps to send a PR to update the themes? Would this work?

Step 1:

# Fork and clone this repo
git submodule update --init --recursive
git submodule update --remote --merge
git commit -am "Update All Submodules"

Step 2: Create a PR with this commit in this repo. (It'd look like this https://github.com/welpo/themes/commit/13a44b43395d613876893e854045fff7c3bc1d0a)

Step 3:

python generate_docs.py /tmp/docs

And use this output to create a PR to the main Zola repo, in this directory: https://github.com/getzola/zola/tree/master/docs/content/themes

Is this correct? I'd gladly help update the themes docs if I knew how to.

@Jieiku
Copy link
Contributor

Jieiku commented Aug 21, 2023

I do this as part of my bash script that generates this page: https://github.com/Jieiku/zola-themes-benchmarks/blob/main/README.md

This allows me to scrape each submodule for relevant info (and new themes), here is how I update:

git clone https://github.com/getzola/themes
cd themes

git submodule foreach --recursive git reset --hard
git reset --hard

git pull
git submodule update --init --recursive
git submodule update --remote --merge

mkdir -p ~/themes-docs
python generate_docs.py ~/themes-docs

The above updates all the submodules, but the generate_docs.py command just ouputs to a folder that I created... so I am not so sure about that part. (would think those generated docs need to go someplace as part of a new git commit.)

@Keats
Copy link
Collaborator Author

Keats commented Aug 21, 2023

I didn't merge getzola/zola#2279 yet, doing it now

As for updating the themes: https://github.com/getzola/themes#updating-all-themes
Run the command above and do a PR. When it's merged, it will automatically create a PR to update the Zola site

@welpo
Copy link
Contributor

welpo commented Aug 21, 2023

I see, thanks for the reply.

I noticed getzola/zola#2279 hasn't actually updated my theme's (tabi) info. Both the README.md and the theme.toml seem to have been ignored. The only change is the Last updated.

Any idea why that might be? If I build the docs manually, it looks fine.

@Keats
Copy link
Collaborator Author

Keats commented Aug 21, 2023

Not sure, git doesn't seem to pick up the changes in that repo for some reason?

@welpo
Copy link
Contributor

welpo commented Aug 22, 2023

Hm. Any suggestions as to how I can begin troubleshooting this? The GitHub action logs appear to show a successful connection to my repo.

In the meantime, would it be acceptable for me to do a manual PR with the updated docs?

@Keats
Copy link
Collaborator Author

Keats commented Aug 22, 2023

I'll have a look tonight

@welpo
Copy link
Contributor

welpo commented Sep 13, 2023

Any updates, @Keats? Any way I can help?

@Keats
Copy link
Collaborator Author

Keats commented Sep 13, 2023

Sorry, I won't have time these upcoming weeks. It's just a matter of checking what git says though

@welpo
Copy link
Contributor

welpo commented Sep 13, 2023

I can't figure out why your commit didn't pick up the changes on my theme.

Since I can update it just fine following https://github.com/getzola/themes#updating-all-themes, I've opened a PR (#123) to update all themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants