-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App Submission: cobalt #2174
App Submission: cobalt #2174
Conversation
App Submission: LinkStack - Self-hosted open-source Linktree alternative
Hey @nmfretz Just for your information: The developers of Cobalt didn't provide a Docker image with UI support, so I built one myself. The app is truly amazing, and I’d love to see this PR merged. 🚀 Port mapping to 9000 is needed. External access is required to this port because it is not proxied by the app_proxy. Thanks for reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dennysubke! Another great submission!
Added some points that should be changed. Also I think you can remove the directory as the cookies.json would not make a lot of sense now.
Tested it without it and everything worked just fine.
cobalt/umbrel-app.yml
Outdated
manifestVersion: 1 | ||
id: cobalt | ||
name: cobalt | ||
tagline: A media downloader that doesn't piss you off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the tagline from their repo.
tagline: A media downloader that doesn't piss you off | |
tagline: Best way to save what you love |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I knew it wouldn't go through! 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahaha
All changes have been made now! Thanks again @al-lac for your help and feedback! 😊 |
Excellent, thanks @dennysubke. Great initiative creating the image 👌. And thanks for reviewing @al-lac. I've changed the API to the nearest free port ( Something to consider: how do you feel about moving the note about the processing server config higher in the app description? This way it's not hidden until the user clicks "read more" in the app store. If the user doesn't set this then they'll be using cobalt's server instead which may not be clear to the average user. If we don't want a
|
Thanks for the feedback and suggestions @nmfretz! I agree with moving the note higher in the app description to make it more visible. Also, I think using a settings icon ⚙️ instead of the |
|
Severity | File | Description |
---|---|---|
ℹ️ | cobalt/docker-compose.yml |
External port mapping "9013:9000": Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.). |
cobalt/umbrel-app.yml |
"icon" and "gallery" needs to be empty for new app submissions: The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team. |
Legend
Symbol | Description |
---|---|
❌ | Error: This must be resolved before this PR can be merged. |
Warning: This is highly encouraged to be resolved, but is not strictly mandatory. | |
ℹ️ | Info: This is just for your information. |
Thanks again @dennysubke. I'm sending this live now with 4 of the gallery assets and then will add the 5th one with port 9013 instead of 9000 soon. ![]() |
Thanks @nmfretz! Do you want me to take care of adding the 5th gallery asset with port 9013, or do you already have it covered? |
App Submission
cobalt
...
Icon
...
Gallery images
...
I have tested my app on: