Migrate hamster plugin to use GIO dbus #676
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neui
force-pushed
the
hamster-to-gio-dbus
branch
from
c622a5d
to
8a67286
Compare
Neui
changed the title
Neui
force-pushed
the
hamster-to-gio-dbus
branch
from
8a67286
to
da26160
Compare
flavin
approved these changes
Feb 7, 2022
|
Hi @Neui, please rebase this for 0.7 :) |
5 tasks
nekohayo
added
plugins
Closed
diegogangl
removed this from the 0.7: "Getting things Gradius — Destroy the core!" milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking this as a draft since this is 'WIP'.Primarily, it needs testing whenever it still works (and whenever catching the exception that way is correct). UghReady for review now. I believe this is the last instance the old dbus python package is being used, so I think we can remove that dependency after merging this PR.