Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Build with Go 1.22 and 1.23; update Vault to 1.14 #1531

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

reneleonhardt
Copy link

@reneleonhardt reneleonhardt commented Jun 16, 2024

Features

  • CI builds both latest Go versions (1.22 and 1.23)

Tech Debt

  • I upgraded VAULT_VERSION to the old 1.14.0, but a new version 1.15.0 of the API has been released last week, and the latest binary is 1.17.5.

Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

.github/workflows/cli.yml Outdated Show resolved Hide resolved
@felixfontein
Copy link
Contributor

@reneleonhardt ping

@reneleonhardt
Copy link
Author

Please squash before/upon merging, I left separate commits for transparency.

@felixfontein felixfontein changed the title feat(build): Build last 2 Go versions CI: Build with Go 1.22 and 1.23; update Vault to 1.14 Sep 14, 2024
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@getsops/maintainers I think for merging this the branch protections for main (?) need to be updated. Right now several CI runs are expected to pass that no longer exist under their old name. I don't have permissions to actually see these parts of the repository settings. Can someone with appropriate rights take a look please?

@felixfontein
Copy link
Contributor

@getsops/maintainers I think for merging this the branch protections for main (?) need to be updated. Right now several CI runs are expected to pass that no longer exist under their old name. I don't have permissions to actually see these parts of the repository settings. Can someone with appropriate rights take a look please?

To simplify this now (and in the future) I created #1621 which allows to modify the branch protections so they depend on only one single 'check' test. Once that is merged and the branch protections adjusted, this can be rebased and then merged without further updating of the branch protections.

I hope that's ok @getsops/maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants