Allow to pass multiple paths to 'updatekeys' #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sj14
force-pushed
the
sj/updatekeys-inputs
branch
6 times, most recently
from
2184382 to
319c322
Compare
sj14
changed the title
hiddeco
reviewed
Sep 11, 2023
sj14
force-pushed
the
sj/updatekeys-inputs
branch
2 times, most recently
from
c6fb84d to
0cde35a
Compare
hiddeco
reviewed
Oct 11, 2023
sj14
force-pushed
the
sj/updatekeys-inputs
branch
3 times, most recently
from
404355f to
7488de6
Compare
felixfontein
reviewed
Nov 5, 2023
There was a problem hiding this comment.
The current version makes the return value less usable. I'm not sure whether anyone relied on the return values of the updatekeys command, but in case any did, they are now broken.
How about slightly adjusting the behavior so that in case there is one argument, the old code is used, and if there are at least two arguments, the new code is used?
sj14
force-pushed
the
sj/updatekeys-inputs
branch
3 times, most recently
from
de99cef to
978514f
Compare
Adjusted. I'm also now printing the amount of failed key updates when multiple arguments are used. I hope that's fine. |
felixfontein
approved these changes
Nov 23, 2023
hiddeco
approved these changes
Dec 15, 2023
hiddeco
force-pushed
the
sj/updatekeys-inputs
branch
from
978514f to
071193c
Compare
Signed-off-by: Simon Jürgensmeyer <[email protected]>
hiddeco
force-pushed
the
sj/updatekeys-inputs
branch
from
071193c to
b693f29
Compare
|
@sj14 thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to pass multiple paths to the
updatekeyscommand, e.g.sops updatekeys file1 file2 file3.