ocikms: Oracle Cloud KMS support #1226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deblasis
commented
Jun 23, 2023
Makefile
Outdated
| @@ -36,7 +36,7 @@ generate: keyservice/keyservice.pb.go | |||
| $(GO) generate | |||
|
|
|||
| %.pb.go: %.proto | |||
| protoc --go_out=plugins=grpc:. $< | |||
| protoc --go_out=. --go-grpc_out=require_unimplemented_servers=false:. $< | |||
There was a problem hiding this comment.
This should be the current way of generating files with protoc since 1.20 I believe.
The generated files are also split now as you can see below.
The flag require_unimplemented_servers=false is necessary to preserve the previous functionality.
Please note that I am using:
I have also tried
protoc-gen-go v1.23.0
protoc v3.13.0
but I am still getting errors with the plugin settings.
I don't think this is an issue but just flagging for the reviewer
deblasis
commented
Jun 23, 2023
keyservice/keyservice.proto
Outdated
| @@ -1,5 +1,7 @@ | |||
| syntax = "proto3"; | |||
|
|
|||
| option go_package = "/keyservice"; | |||
There was a problem hiding this comment.
Added this ad best practice and because I was getting errors because of this as well when doing make generate
Signed-off-by: Alessandro De Blasis <[email protected]>
deblasis
force-pushed
the
issue/#981-oci-kms
branch
from
95a366b to
34d2349
Compare
Signed-off-by: Alessandro De Blasis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I found myself needing this so I thought it was a good opportunity to contribute a little.
Happy to make the necessary changes, I tried to comply with style as much as possible.
Fixes #981
cc: @colemickens, @davidpinhas, @b-dean
Basic Demo
sops_oci_kms_demo.mp4