ci(periodic): Use cargo action for clippy #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run clippy with the cargo action. The annotations from the clippy action end up in the wrong place and github can't figure this out. Running the cargo action still annotates via stdout plus it doesn't run the actualy command with json output so humans can read it anyway.
Swatinem
approved these changes
Jan 14, 2021
|
I’m 👍 on this, but I guess @jan-auer will disagree. |
|
BTW, I think this is the ICE that we hit on nightly: rust-lang/rust#81000 |
Not necessarily, but please point me in the right direction. Previously, clippy violations were annotated on the source code. This was a super useful feature, as it showed the suggested fix in line with the diff. Where is this now? Separately, if you know I disagree, could we please hold off merging until we have reached agreement? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Giving up on this.
Run clippy with the cargo action. The annotations from the clippy
action end up in the wrong place and github can't figure this out.
Running the cargo action still annotates via stdout plus it doesn't
run the actualy command with json output so humans can read it anyway.
#skip-changelog