Cache the result of Demangling #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demangling can be an expensive operation, which also happens for every frame and is not deduplicated for the same function names shared across threads. Furthermore, we capture errors for demangling failures, to eventually be able to improve those. However we are being spammed with up to 8 of those errors a second, and they are highly duplicated too, making it difficult to actually find new cases we don’t handle yet. So lets cache all the things, to avoid duplicated work and spamming S4S events.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1124 +/- ##
==========================================
+ Coverage 73.81% 73.89% +0.07%
==========================================
Files 86 86
Lines 12717 12748 +31
==========================================
+ Hits 9387 9420 +33
+ Misses 3330 3328 -2 |
loewenheim
approved these changes
Apr 5, 2023
Comment on lines
+268
to
+278
| ); | ||
| relative_addr.and_then(|addr| { | ||
| symbolicate_native_frame( | ||
| demangle_cache, | ||
| symcache, | ||
| lookup_result, | ||
| addr, | ||
| frame, | ||
| index, | ||
| ) | ||
| }) |
There was a problem hiding this comment.
Nit: IMO this is nicer with ?.
Suggested change
| ); | |
| relative_addr.and_then(|addr| { | |
| symbolicate_native_frame( | |
| demangle_cache, | |
| symcache, | |
| lookup_result, | |
| addr, | |
| frame, | |
| index, | |
| ) | |
| }) | |
| )?; | |
| symbolicate_native_frame( | |
| demangle_cache, | |
| symcache, | |
| lookup_result, | |
| relative_addr, | |
| frame, | |
| index, | |
| ) |
Swatinem
added a commit
that referenced
this pull request
Apr 6, 2023
A followup to this review comment: #1124 (review)
Swatinem
added a commit
that referenced
this pull request
Apr 6, 2023
A followup to this review comment: #1124 (review)
Swatinem
added a commit
that referenced
this pull request
Apr 6, 2023
A followup to this review comment: #1124 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demangling can be an expensive operation, which also happens for every frame and is not deduplicated for the same function names shared across threads. Furthermore, we capture errors for demangling failures, to eventually be able to improve those. However we are being spammed with up to 8 of those errors a second, and they are highly duplicated too, making it difficult to actually find new cases we don’t handle yet.
So lets cache all the things, to avoid duplicated work and spamming S4S events.
The change to
get_relative_caller_addris a driveby refactoring as clippy was rightfully complaining about too many fn arguments.#skip-changelog