Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ members = ["symbolic*", "examples/*"]

[workspace.package]
edition = "2021"
rust-version = "1.73"
rust-version = "1.82"

[workspace.dependencies]
anyhow = "1.0.32"
Expand All @@ -21,12 +21,12 @@ elementtree = "1.2.3"
elsa = "1.8.0"
fallible-iterator = "0.3.0"
flate2 = { version = "1.0.25", default-features = false, features = [
"rust_backend",
"rust_backend",
] }
gimli = { version = "0.31.0", default-features = false, features = [
"read",
"std",
"fallible-iterator",
"read",
"std",
"fallible-iterator",
] }
goblin = { version = "0.8.0", default-features = false }
indexmap = "2.0.0"
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ To run these examples, use the `run` script. For example:
Symbolic tries to not break MSRV compatibility but makes no guarantees about the Rust version.
Although you can expect Rust version compatibility of **at least 6 months**.

The current MSRV is 1.73.
The current MSRV is 1.82.

## License

Expand Down
8 changes: 2 additions & 6 deletions symbolic-cabi/src/core.rs
Original file line number Diff line number Diff line change
Expand Up @@ -351,11 +351,7 @@ pub unsafe extern "C" fn symbolic_str_free(string: *mut SymbolicStr) {
/// Returns true if the uuid is nil.
#[no_mangle]
pub unsafe extern "C" fn symbolic_uuid_is_nil(uuid: *const SymbolicUuid) -> bool {
if let Ok(uuid) = Uuid::from_slice(&(*uuid).data[..]) {
uuid == Uuid::nil()
} else {
false
}
Uuid::from_bytes((*uuid).data) == Uuid::nil()
}

/// Formats the UUID into a string.
Expand All @@ -364,6 +360,6 @@ pub unsafe extern "C" fn symbolic_uuid_is_nil(uuid: *const SymbolicUuid) -> bool
/// `symbolic_cstr_free`.
#[no_mangle]
pub unsafe extern "C" fn symbolic_uuid_to_str(uuid: *const SymbolicUuid) -> SymbolicStr {
let uuid = Uuid::from_slice(&(*uuid).data[..]).unwrap_or_default();
let uuid = Uuid::from_bytes((*uuid).data);
SymbolicStr::from_string(uuid.hyphenated().to_string())
}
5 changes: 1 addition & 4 deletions symbolic-cfi/tests/snapshots/test_cfi__cfi_elf.snap
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
---
created: "2019-07-05T18:52:40.332785Z"
creator: [email protected]
source: minidump/tests/test_cfi.rs
source: symbolic-cfi/tests/test_cfi.rs
expression: cfi
---
STACK CFI INIT 1dc0 2a .cfa: $rsp 8 +
Expand Down Expand Up @@ -1502,4 +1500,3 @@ STACK CFI 14c90 .cfa: $rsp 24 +
STACK CFI 14c92 .cfa: $rsp 16 +
STACK CFI 14c94 .cfa: $rsp 8 +
STACK CFI INIT 14ca0 2 .cfa: $rsp 8 + .ra: .cfa -8 + ^

4 changes: 1 addition & 3 deletions symbolic-cfi/tests/snapshots/test_cfi__cfi_macho.snap
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
---
source: symbolic-minidump/tests/test_cfi.rs
source: symbolic-cfi/tests/test_cfi.rs
expression: cfi

---
STACK CFI INIT d20 1a .cfa: $rsp 8 + .ra: .cfa -8 + ^
STACK CFI INIT d40 1a .cfa: $rsp 8 + .ra: .cfa -8 + ^
Expand Down Expand Up @@ -302,4 +301,3 @@ STACK CFI INIT db50 41 .cfa: $rsp 8 + .ra: .cfa -8 + ^
STACK CFI db51 .cfa: $rsp 16 +
STACK CFI INIT dba0 d0 .cfa: $rsp 320 + .ra: .cfa -8 + ^ $rbx: .cfa -16 + ^
STACK CFI INIT dc70 34 .cfa: $rsp 16 + .ra: .cfa -8 + ^ $rbx: .cfa -16 + ^

5 changes: 1 addition & 4 deletions symbolic-cfi/tests/snapshots/test_cfi__cfi_pdb_windows.snap
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
---
created: "2019-04-03T18:49:08.328347Z"
creator: [email protected]
source: minidump/tests/test_cfi.rs
source: symbolic-cfi/tests/test_cfi.rs
expression: cfi
---
STACK WIN 4 1000 114 11 0 8 0 0 0 1 $T0 .raSearch = $eip $T0 ^ = $esp $T0 4 + =
Expand Down Expand Up @@ -156,4 +154,3 @@ STACK WIN 4 358f 187 0 0 0 4 24 0 1 $T0 $ebp = $eip $T0 4 + ^ = $ebp $T0 ^ = $es
STACK WIN 4 35b7 ef 0 0 0 8 24 0 1 $T0 $ebp = $eip $T0 4 + ^ = $ebp $T0 ^ = $esp $T0 8 + = $20 $T0 40 - ^ = $23 $T0 44 - ^ =
STACK WIN 4 35b8 ed 0 0 0 c 24 0 1 $T0 $ebp = $eip $T0 4 + ^ = $ebp $T0 ^ = $esp $T0 8 + = $20 $T0 40 - ^ = $23 $T0 44 - ^ = $24 $T0 48 - ^ =
STACK WIN 4 371a c 0 0 0 0 0 0 1 $T0 .raSearch = $eip $T0 ^ = $esp $T0 4 + =

2 changes: 0 additions & 2 deletions symbolic-cfi/tests/snapshots/test_cfi__cfi_pe_windows.snap
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
---
source: symbolic-cfi/tests/test_cfi.rs
assertion_line: 105
expression: cfi
---
STACK CFI INIT 1010 55 .cfa: $rsp 80 + $rbx: .cfa 16 - ^ $rsi: .cfa 24 - ^ $rdi: .cfa 32 - ^ .ra: .cfa 8 - ^
Expand Down Expand Up @@ -44,4 +43,3 @@ STACK CFI INIT 1de8 1b9 .cfa: $rsp 48 + $rsi: .cfa 16 - ^ $rdi: .cfa 24 - ^ $r14
STACK CFI INIT 2090 2 .cfa: $rsp 8 + .ra: .cfa 8 - ^
STACK CFI INIT 20ac 1e .cfa: $rsp 48 + $rbp: .cfa 16 - ^ .ra: .cfa 8 - ^
STACK CFI INIT 20ca 18 .cfa: $rsp 16 + $rbp: .cfa 16 - ^ .ra: .cfa 8 - ^

5 changes: 1 addition & 4 deletions symbolic-cfi/tests/snapshots/test_cfi__cfi_sym_linux.snap
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
---
created: "2019-02-20T15:42:11.809248Z"
creator: [email protected]
source: minidump/tests/test_cfi.rs
source: symbolic-cfi/tests/test_cfi.rs
expression: cfi
---
STACK CFI INIT 1dc0 2a .cfa: $rsp 8 + .ra: .cfa -8 + ^
Expand Down Expand Up @@ -1502,4 +1500,3 @@ STACK CFI 14c90 .cfa: $rsp 24 +
STACK CFI 14c92 .cfa: $rsp 16 +
STACK CFI 14c94 .cfa: $rsp 8 +
STACK CFI INIT 14ca0 2 .cfa: $rsp 8 + .ra: .cfa -8 + ^

5 changes: 1 addition & 4 deletions symbolic-cfi/tests/snapshots/test_cfi__cfi_sym_macos.snap
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
---
created: "2019-02-20T15:42:11.796554Z"
creator: [email protected]
source: minidump/tests/test_cfi.rs
source: symbolic-cfi/tests/test_cfi.rs
expression: cfi
---
STACK CFI INIT d20 1a .cfa: $rsp 8 + .ra: .cfa -8 + ^
Expand Down Expand Up @@ -217,4 +215,3 @@ STACK CFI INIT db30 a .cfa: $rsp 8 + .ra: .cfa -8 + ^
STACK CFI INIT db40 a .cfa: $rsp 8 + .ra: .cfa -8 + ^
STACK CFI INIT db50 41 .cfa: $rsp 8 + .ra: .cfa -8 + ^
STACK CFI db51 .cfa: $rsp 16 +

5 changes: 1 addition & 4 deletions symbolic-cfi/tests/snapshots/test_cfi__cfi_sym_windows.snap
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
---
created: "2019-02-20T15:42:11.796623Z"
creator: [email protected]
source: minidump/tests/test_cfi.rs
source: symbolic-cfi/tests/test_cfi.rs
expression: cfi
---
STACK WIN 4 1000 114 11 0 8 0 0 0 1 $T0 .raSearch = $eip $T0 ^ = $esp $T0 4 + =
Expand Down Expand Up @@ -158,4 +156,3 @@ STACK WIN 4 35b8 ed 0 0 0 c 24 0 1 $T0 $ebp = $eip $T0 4 + ^ = $ebp $T0 ^ = $esp
STACK WIN 4 371a c 0 0 0 0 0 0 1 $T0 .raSearch = $eip $T0 ^ = $esp $T0 4 + =
STACK WIN 0 2dc4 14 0 0 0 0 0 0 0 0
STACK WIN 0 30fc 13 0 0 0 0 0 0 0 0

2 changes: 1 addition & 1 deletion symbolic-common/src/path.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ fn is_windows_driveletter<P: AsRef<[u8]>>(path: P) -> bool {

if let (Some(drive_letter), Some(b':')) = (path.first(), path.get(1)) {
if drive_letter.is_ascii_alphabetic() {
return path.get(2).map_or(true, is_windows_separator);
return path.get(2).is_none_or(is_windows_separator);
}
}

Expand Down
Loading
Loading