Skip to content

fix(swift): Remove unnecessary assert in swift demangler #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

fix(swift): Remove unnecessary assert in swift demangler #917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

**Fixes**

- demangle: Fixed a crash/abort when providing bad input to the swift demangler. ([#917](https://github.com/getsentry/symbolic/pull/917))

## 12.15.4

**Fixes**
Expand Down
11 changes: 11 additions & 0 deletions symbolic-demangle/vendor/swift/1-arguments.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,14 @@ index 6c309bbf..5b251e8d 100644
return;

if (isAsync)
diff --git a/symbolic-demangle/vendor/swift/lib/Demangling/Demangler.cpp b/symbolic-demangle/vendor/swift/lib/Demangling/Demangler.cpp
index 6c309bbf..5b251e8d 100644
--- a/symbolic-demangle/vendor/swift/lib/Demangling/Demangler.cpp
+++ b/symbolic-demangle/vendor/swift/lib/Demangling/Demangler.cpp
@@ -3423,7 +3423,6 @@ NodePointer Demangler::demangleSpecAttributes(Node::Kind SpecKind) {

int PassID = (int)nextChar() - '0';
if (PassID < 0 || PassID >= MAX_SPECIALIZATION_PASS) {
- assert(false && "unexpected pass id");
return nullptr;
}
1 change: 0 additions & 1 deletion symbolic-demangle/vendor/swift/lib/Demangling/Demangler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3423,7 +3423,6 @@ NodePointer Demangler::demangleSpecAttributes(Node::Kind SpecKind) {

int PassID = (int)nextChar() - '0';
if (PassID < 0 || PassID >= MAX_SPECIALIZATION_PASS) {
assert(false && "unexpected pass id");
return nullptr;
}

Expand Down
Loading