feat: Add SourceLink support to SourceBundles #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kamilogorek
approved these changes
Jul 13, 2023
Swatinem
approved these changes
Jul 14, 2023
Comment on lines
913
to
914
| match self.index.indexed_files.get(&key) { | ||
| Some(zip_path) => { |
There was a problem hiding this comment.
I would prefer an if let Some() with an early return, but thats just preference :-)
Comment on lines
921
to
923
| let FileKey::Path(path) = key else { | ||
| return Ok(None); | ||
| }; |
There was a problem hiding this comment.
fun fact, now that we have rustfmt support for let-else, if you remove the ; from the inner return, it will keep auto-formating things onto a single line, if it was on a single line to begin with.
Co-authored-by: Arpad Borsos <[email protected]>
loewenheim
force-pushed
the
feat/sourcebundle-sourcelinks
branch
from
76f02ee to
bcf3f6d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #804 +/- ##
==========================================
+ Coverage 74.80% 74.89% +0.08%
==========================================
Files 63 63
Lines 15603 15656 +53
==========================================
+ Hits 11672 11725 +53
Misses 3931 3931 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #803.
This adds a
source_linksmap to the sourcebundle manifest, but for now there are no methods for populating it. Lookup functionality is included, however.