fix: Completely skip over hidden sequence points #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a bit unclear how to really treat these, however just setting the line to `0` means we correctly symbolicate, but then later on we apply the wrong source context lines. By ignoring these, we do get the correct source line (and thus source context) for a specific customer issue.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #769 +/- ##
=======================================
Coverage 74.67% 74.67%
=======================================
Files 71 71
Lines 15400 15401 +1
=======================================
+ Hits 11500 11501 +1
Misses 3900 3900 |
kamilogorek
approved these changes
Mar 1, 2023
loewenheim
approved these changes
Mar 1, 2023
|
As you point out in the linked issue, none of us can tell what these are supposed to be for. I think skipping them entirely is reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a bit unclear how to really treat these hidden sequence points.
However just setting the line to
0means we do find a source location (with line0) on lookup, and then later on we apply the wrong source context lines.By ignoring these, we do get the correct source line (and thus source context) for the linked customer issue.
If just skipping these is really the way we want to go:
fixes #768
fixes https://github.com/getsentry/team-stacktrace-private/issues/28