Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: partially expose embedded PPDB in PE #756

Closed
wants to merge 6 commits into from

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Feb 6, 2023

part of #750

This is an abandoned approach and replaced by #757 in combination with getsentry/sentry-cli#1463 but maybe we want to cherry-pick some things from this PR before closing & removing?

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against e53a978

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #756 (6ab8ff5) into master (2fe64b8) will increase coverage by 0.09%.
The diff coverage is 92.50%.

❗ Current head 6ab8ff5 differs from pull request most recent head e53a978. Consider uploading reports for the commit e53a978 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
+ Coverage   73.88%   73.97%   +0.09%     
==========================================
  Files          69       69              
  Lines       14951    14970      +19     
==========================================
+ Hits        11046    11074      +28     
+ Misses       3905     3896       -9     

@vaind vaind closed this Feb 16, 2023
@vaind vaind deleted the feat/pe-embedded-ppdb-access branch February 16, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant