Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Use watto for ppdb and symcache parsing #670

Merged
merged 17 commits into from
Sep 21, 2022
Merged

ref: Use watto for ppdb and symcache parsing #670

merged 17 commits into from
Sep 21, 2022

Conversation

loewenheim
Copy link
Contributor

@loewenheim loewenheim commented Aug 31, 2022

This factors out some of the repetitive parsing code in symbolic-symcache and symbolic-ppdb into the new watto crate. Since watto stores strings differently than current symcache, this also requires us to bump the version of symcache from 7 to 8.

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Merging #670 (b171930) into master (2bed7d2) will decrease coverage by 0.22%.
The diff coverage is 90.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
- Coverage   73.32%   73.09%   -0.23%     
==========================================
  Files          84       84              
  Lines       17531    17382     -149     
==========================================
- Hits        12854    12705     -149     
  Misses       4677     4677              

@loewenheim loewenheim marked this pull request as ready for review September 12, 2022 15:16
@loewenheim loewenheim requested a review from a team September 12, 2022 15:16
symbolic-symcache/src/lib.rs Outdated Show resolved Hide resolved
symbolic-symcache/src/lib.rs Outdated Show resolved Hide resolved
@Swatinem Swatinem merged commit 2411baf into master Sep 21, 2022
@Swatinem Swatinem deleted the ref/watto branch September 21, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants