Rework the symcache writer for correctness #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstange
force-pushed
the
symcache-writer-rework
branch
2 times, most recently
from
8c5b278 to
1275d64
Compare
This commit also reverts the public API `SymCacheConverter::process_symbolic_function` back to its 9.0.0 signature. Fixes getsentry#646. Fixes getsentry#647. Before this fix, for each function in the inlinee tree we inserted an entry into `self.ranges` for every line address. These entries were overwritten repeatedly as we descendent into the inlinees. Now we just insert entries for address ranges which are not covered by the function's inlinees. And we no longer insert entries for "parent lines" from within a callee; every function only inserts its own lines and knows where to split.
mstange
force-pushed
the
symcache-writer-rework
branch
from
1275d64 to
87033c5
Compare
Swatinem
approved these changes
Aug 3, 2022
Comment on lines
+197
to
+198
| // (1) Instructions which are part of an inlined function call, and | ||
| // (2) instructions which are *not* part of an inlined function call. |
There was a problem hiding this comment.
the "part of" might be a bit confusing here.
maybe:
(1) Instructions which are in the middle of an inlined call chain, and
(2) instructions which do not have further callees.
That’s not too good of an explanation either though :-D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #646 and #647. I think it's also simpler; we iterate over the inlinees twice, but at least the responsibility of who inserts what range is clear now.
Overall it's about 50 more lines of code, but those extra lines are just comments.
Commit message for the squashed commit: