Make dsym_parent accept .framework.dSYM #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
DSymPathExt::dsym_parentexpects the bundle name to be exactlyFramework.dSYM, but for frameworks it can also beFramework.framework.dSYM. This change makes it accept either.I ran into this issue trying to use symbolic with dSYM bundles from our framework at FullStory. The path to the DWARF file in them is
FullStory.framework.dSYM/Contents/Resources/DWARF/FullStory. I created a new framework project in Xcode and archived it to verify that we weren't doing anything nonstandard. The resulting dSYM is included as a test fixture in this PR, you can see that it's namedExample.framework.dSYM.