feat(demangle): Improve docs for symbolic-demangle #241
Conversation
jan-auer
force-pushed
the
feat/demangle-docs
branch
2 times, most recently
from
6575382 to
4087730
Compare
jan-auer
force-pushed
the
feat/demangle-docs
branch
from
4087730 to
8de57c6
Compare
demangle/Cargo.toml
Outdated
| @@ -25,5 +26,11 @@ msvc-demangler = "0.8.0" | |||
| rustc-demangle = "0.1.16" | |||
| symbolic-common = { version = "7.3.3", path = "../common" } | |||
|
|
|||
| [dev-dependencies] | |||
| symbolic = { path = "..", features = ["demangle"] } | |||
There was a problem hiding this comment.
Just a heads up… I know this pattern is super useful, as I have also used it for the rust SDK, but you are not able to properly publish with this: rust-lang/cargo#4242 😭
There was a problem hiding this comment.
Alright, let me revert this then. Too bad, it made the examples much nicer.
There was a problem hiding this comment.
Yes it definitely does! I’m also not yet sure what I should do about this for the SDK, since I depend on sentry::init and sentry::test a lot in the doctests 😭
There was a problem hiding this comment.
For the Sentry SDK, doing something similar to futures would probably be worth it. In symbolic, I guess people can extrapolate how to rewrite the imports until there's a proper solution for this in cargo.
Updates docs of
symbolic-demangle, as they were out of date and sometimes incomplete. Particularly, this includes:cargo-readme