feat(minidump): Return ProcessStates for minidumps without threads #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
May 16, 2019
jan-auer
added a commit
that referenced
this pull request
May 23, 2019
) Fix for #144. Also fixes a memory leak if the minidump cannot be opened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns a
ProcessStateeven if the minidump contains no thread list.The thread list is retrieved as the last processing step, immediately before symbolication. As such, system information and exception information might still be available. It's better to return this partial process state than fully bailing out.
https://github.com/google/breakpad/blob/d930308bbbfa089a63df67c4f78065604494d39d/src/processor/minidump_processor.cc#L156-L160