-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(deletes): bulk delete consumer #6510
base: master
Are you sure you want to change the base?
Conversation
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Adds better typing to the delete pipeline as well separates some code out from #6510. To avoid circular imports, it's easier to have `bulk_delete_query` file almost import from `delete_query`, and never have `delete_query` import from `bulk_delete_query` (where the ConditionsType was before)
6ee920c
to
4a6cd97
Compare
For the batching file I added, I've also added it into arroyo itself: getsentry/arroyo#390 though I don't think that should be a blocker for this PR. Just was something I thought would clean up the duplicate work - if folks think it makes sense to add to arroyo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Left a few comments and questions.
context:
The work for bulk deleting in snuba has so far included the following:
what's left:
Now that we have the topics created we can finish up the consumer side.
this PR:
It's a bit of a larger PR but it can be reviewed in a couple sections:
strategy.py
file has the details for actually executing the delete querybatching.py
file - I have an arroyo PR that makes this file obsolete but in the meantime I don't think it needs to block this PR since it will be easy to remove afterDELETE
query is up to that logic.