feat: Add EAP span subscriptions for devserver #6396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
shruthilayaj
commented
Oct 8, 2024
| @@ -129,3 +129,9 @@ mandatory_condition_checkers: | |||
| stream_loader: | |||
| processor: EAPSpansMessageProcessor | |||
| default_topic: snuba-spans | |||
| commit_log_topic: snuba-eap-spans-commit-log | |||
There was a problem hiding this comment.
I want to call out that this topic doesn't exist in production (double/triple checking this is ok)
| @@ -28,7 +28,7 @@ python-dateutil==2.8.2 | |||
| python-rapidjson==1.8 | |||
| redis==4.3.4 | |||
| sentry-arroyo==2.17.6 | |||
| sentry-kafka-schemas==0.1.112 | |||
| sentry-kafka-schemas==0.1.113 | |||
There was a problem hiding this comment.
includes this change getsentry/sentry-kafka-schemas#337
untitaker
reviewed
Oct 8, 2024
| @@ -170,6 +170,30 @@ def devserver(*, bootstrap: bool, workers: bool) -> None: | |||
| "--auto-offset-reset=latest", | |||
| ], | |||
| ), | |||
| ( | |||
There was a problem hiding this comment.
there is an else-branch where you should add the same consumer again. normally in devserver, SEPARATE_SCHEDULER_EXECUTOR_SUBSCRIPTIONS_DEV is False, and subscription executor+scheduler are running in a single consumer (for lower resource usage)
untitaker
approved these changes
Oct 8, 2024
shruthilayaj
deleted the
shruthi/feat/eap-span-subscriptions-for-devserver
branch
|
PR reverted: ff04932 |
getsentry-bot
added a commit
that referenced
this pull request
Oct 8, 2024
This reverts commit 4db5589. Co-authored-by: untitaker <[email protected]>
shruthilayaj
restored the
shruthi/feat/eap-span-subscriptions-for-devserver
branch
shruthilayaj
added a commit
that referenced
this pull request
Oct 9, 2024
Same as #6396, since deploying it without the commit log topic in prod caused the EAP consumer to crash. getsentry/ops#12369 added the commit log topic to prod. Also deployed the snuba-k8s pipeline to all regions. To enable dev work on EAP alerts, this PR starts an alerts scheduler and executor for EAP span alerts. It adds dataset configuration for span alerts to work (including enabling commit logs for EAP spans).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable dev work on EAP alerts, this PR starts an alerts scheduler and executor for EAP span alerts in "separate scheduler and executor mode" with snuba devserver.
It adds dataset configuration for span alerts to work (including enabling commit logs for EAP spans).