Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): Update tags list rpc #6301

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

Zylphrex
Copy link
Member

sentry-protos 0.1.21 changes the definition a bit, updating the endpoint to accept it.

sentry-protos 0.1.21 changes the definition a bit, updating the endpoint to accept it.
Copy link

codecov bot commented Sep 13, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2614 1 2613 4
View the top 1 failed tests by shortest run time
tests.web.rpc.test_span_samples.TestSpanSamples test_basic
Stack Traces | 0.251s run time
Traceback (most recent call last):
  File ".../web/rpc/test_span_samples.py", line 146, in test_basic
    assert response.status_code == 200, response.text
AssertionError: {
      "error": {
          "type": "internal_server_error",
          "message": "virtual_column_context"
      }
  }
assert 500 == 200
 +  where 500 = <WrapperTestResponse streamed [500 INTERNAL SERVER ERROR]>.status_code

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

Copy link
Member

@volokluev volokluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yeah thanks Tony

@Zylphrex Zylphrex merged commit b43bf24 into master Sep 13, 2024
30 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/update-tags-list-rpc branch September 13, 2024 17:07
wmak pushed a commit to getsentry/sentry that referenced this pull request Sep 17, 2024
This uses RPC calls to fetch tag keys from eap spans.

Depends on getsentry/snuba#6301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants