Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(clickhouse): update versions and add 24.3 #6246

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ref(clickhouse): update versions and add 24.3 #6246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,7 @@ jobs:
version:
[
"23.8.11.29.altinitystable",
"24.3.5.47.altinitystable",
]

steps:
Expand Down
9 changes: 5 additions & 4 deletions snuba/migrations/clickhouse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
CLICKHOUSE_SERVER_MIN_VERSION = "21.8.12.29"
# Note: 21.8.12.29 and 21.8.13.1 are used in self-hosted builds
# even though SaaS clusters are all on 22.8 or above
CLICKHOUSE_SERVER_MAX_VERSION = "23.8.11.29"
CLICKHOUSE_SERVER_MIN_VERSION = "22.8.15.25"
# Note: some test regions are using 22.8.15.25.
# 23.8.11.29 is the base image for self-hosted and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which ones?

Copy link
Member Author

@MeredithAnya MeredithAnya Aug 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volokluev I linked them in the PR description (or rather one example), I'm not sure if they are still in use. So we could possibly raise this to 23.3

# saas clusters should be on 23.8.11.29
CLICKHOUSE_SERVER_MAX_VERSION = "24.3.5.47"
Loading