feat(profiling): Add profiler id column to transactions (#6099) #6103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-applying #6099. For continuous profiling, the profile context will contain a new value `profiler_id`, not to be confused with `profile_id`. A `profiler_id` is set on the transaction's profile context when the continuous profiler is enabled. This is a separate value from the existing `profile_id` because we need to be able to distinguish if the transaction is associated with a transaction based profile or a continuous profile and load the profile from the correct place.
|
This PR has a migration; here is the generated SQL -- start migrations
-- forward migration transactions : 0023_add_profiler_id_column
Local op: ALTER TABLE transactions_local ADD COLUMN IF NOT EXISTS profiler_id Nullable(UUID) AFTER profile_id;
Distributed op: ALTER TABLE transactions_dist ADD COLUMN IF NOT EXISTS profiler_id Nullable(UUID) AFTER profile_id;
-- end forward migration transactions : 0023_add_profiler_id_column
-- backward migration transactions : 0023_add_profiler_id_column
Distributed op: ALTER TABLE transactions_dist DROP COLUMN IF EXISTS profiler_id;
Local op: ALTER TABLE transactions_local DROP COLUMN IF EXISTS profiler_id;
-- end backward migration transactions : 0023_add_profiler_id_column |
nikhars
approved these changes
Jul 15, 2024
Zylphrex
added a commit
that referenced
this pull request
Jul 16, 2024
Follow up to #6103 to begin writing the profiler_id value to the transactions table.
This was referenced Jul 16, 2024
Zylphrex
added a commit
that referenced
this pull request
Jul 18, 2024
Follow up to #6103 to begin writing the profiler_id value to the transactions table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-applying #6099.
For continuous profiling, the profile context will contain a new value
profiler_id, not to be confused withprofile_id. Aprofiler_idis set on the transaction's profile context when the continuous profiler is enabled. This is a separate value from the existingprofile_idbecause we need to be able to distinguish if the transaction is associated with a transaction based profile or a continuous profile and load the profile from the correct place.