Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(rs): some docs for the ClickHouse batch module #6020

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

onewland
Copy link
Contributor

I wanted to check my own understanding here, and if people think it's useful then we can go ahead and merge.

@onewland onewland requested a review from a team as a code owner June 11, 2024 17:58
@onewland onewland requested a review from a team June 11, 2024 17:58
@@ -12,18 +12,27 @@ use tokio_stream::wrappers::ReceiverStream;
use crate::runtime_config::get_str_config;
use crate::types::RowData;

const CLICKHOUSE_HTTP_CHUNK_SIZE: usize = 1_000_000;
const CLICKHOUSE_HTTP_CHUNK_SIZE_BYTES: usize = 1_000_000;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good but references to this constant need fixing

Copy link

codecov bot commented Jun 12, 2024

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 95 tests with 1 failed, 94 passed and 0 skipped.

View the full list of failed tests
Test Description Failure message
Testsuite:
pytest

Test name:
tests.test_cleanup.TestCleanup::test_midnight_error_case[transactions]

Envs:
- default
Traceback (most recent call last):
File ".../snuba/tests/test_cleanup.py", line 218, in test_midnight_error_case
assert [(p.date, p.retention_days) for p in parts] == [
AssertionError: assert [] == [(datetime.datetime(2021, 10, 25, 0, 0), 90)]
Right contains one more item: (datetime.datetime(2021, 10, 25, 0, 0), 90)
Full diff:
- [(datetime.datetime(2021, 10, 25, 0, 0), 90)]
+ []

@onewland onewland closed this Jun 12, 2024
@onewland onewland reopened this Jun 12, 2024
@onewland onewland merged commit dfb5d93 into master Jun 12, 2024
53 of 57 checks passed
@onewland onewland deleted the doc-comments-clickhouse-batch branch June 12, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants