Debugging bucket timer #5963
Merged
Debugging bucket timer #5963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volokluev
reviewed
May 23, 2024
xurui-c
force-pushed
the
rachel/bucketTimerMetrics
branch
from
bc25867
to
4436c6f
Compare
volokluev
reviewed
May 23, 2024
xurui-c
force-pushed
the
rachel/bucketTimerMetrics
branch
from
4436c6f
to
bd13be3
Compare
volokluev
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the debugging efforts on why auto replacements project skipping isn't working as intended, we have a new hypothesis that the bucket timer algo we depend on isn't working as we expected. More specifically, we noticed (from logging) that projects_exceeding_limit logs, but projects_exceeding_time_limit does not. We add additional logging to confirm the control flow of our code